Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RedisGraph #177

Merged
merged 3 commits into from
Sep 3, 2023
Merged

Deprecate RedisGraph #177

merged 3 commits into from
Sep 3, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Aug 24, 2023

@shacharPash shacharPash requested a review from a team August 24, 2023 13:35
@haysch
Copy link
Contributor

haysch commented Aug 24, 2023

Is that the correct wording?
Isn't it still possible to load the RedisGraph module in Redis 7.2?

Only redis-stack (and server) has stopped providing the module AFAIK.

@@ -3,6 +3,7 @@

namespace NRedisStack
{
[Obsolete("RedisGraph is not supported since Redis 7.2 (https://redis.com/blog/redisgraph-eol/)")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed an update to the deprecation text.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d554cd4) 94.04% compared to head (7635b52) 94.04%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          82       82           
  Lines        5086     5086           
  Branches      479      479           
=======================================
  Hits         4783     4783           
  Misses        176      176           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim merged commit a31172e into master Sep 3, 2023
7 checks passed
@chayim chayim deleted the Issue174/DeprecatedGraph branch September 3, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate RedisGraph
4 participants