Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CLIENT SETINFO Command #180

Merged
merged 33 commits into from
Oct 19, 2023
Merged

Support CLIENT SETINFO Command #180

merged 33 commits into from
Oct 19, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Aug 31, 2023

Closes #160
Closes #165

@shacharPash shacharPash changed the title Issue160/client set info Support Client set Aug 31, 2023
@shacharPash shacharPash changed the title Support Client set Support CLIENT SETINFO Command Aug 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (da200b6) 94.03% compared to head (28bc9e0) 94.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   94.03%   94.06%   +0.02%     
==========================================
  Files          82       85       +3     
  Lines        5127     5186      +59     
  Branches      483      488       +5     
==========================================
+ Hits         4821     4878      +57     
- Misses        180      181       +1     
- Partials      126      127       +1     
Files Coverage Δ
src/NRedisStack/Auxiliary.cs 100.00% <100.00%> (ø)
src/NRedisStack/CoreCommands/CoreCommands.cs 100.00% <100.00%> (ø)
src/NRedisStack/CoreCommands/CoreCommandsAsync.cs 100.00% <100.00%> (ø)
src/NRedisStack/CoreCommands/CoreCommandBuilder.cs 77.77% <77.77%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/NRedisStack/Auxiliary.cs Show resolved Hide resolved
src/NRedisStack/Auxiliary.cs Show resolved Hide resolved
src/NRedisStack/Auxiliary.cs Outdated Show resolved Hide resolved
tests/NRedisStack.Tests/Core Commands/CoreTests.cs Outdated Show resolved Hide resolved
src/NRedisStack/Auxiliary.cs Outdated Show resolved Hide resolved
@chayim chayim marked this pull request as ready for review October 19, 2023 08:10
@chayim chayim merged commit aa6f6a4 into master Oct 19, 2023
11 checks passed
@chayim chayim deleted the Issue160/ClientSetInfo branch October 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Dev Containers Clients should identify themselves on connect
4 participants