Support GEOSHAPE field type in RediSearch #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delete mock * coverage * fix test * indent * change to var - check * cluster test * add opthin to connect cluster with dotnet test * use key in topk tests * get env vars inside RedisFixture * skip if redis * add skip where needed * Execute broadcast * delete cluster tests * RedisFixture fix * add to contributing * run cluster on CI * wip * fix / * -d * delete restore * return restore * add -RC3 * add RC3 to docker-compose * try define both .net 6 and 7 * Skip if cluster where needed * add names * skip configOnTimeout if cluster * try to fix win tests * tests names +fix win version * fix versions * versions * win verer * wording * change to OSSCluster * isOSSCluster * update skip reason to OSS cluster * general dispose * general dispose for the rest of the disposes --------- Co-authored-by: Chayim <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 94.06% 94.03% -0.04%
==========================================
Files 82 82
Lines 5109 5127 +18
Branches 483 483
==========================================
+ Hits 4806 4821 +15
- Misses 176 180 +4
+ Partials 127 126 -1
☔ View full report in Codecov by Sentry. |
chayim
reviewed
Oct 16, 2023
chayim
reviewed
Oct 16, 2023
chayim
reviewed
Oct 16, 2023
chayim
reviewed
Oct 16, 2023
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
Examples/GeoShape.md
Outdated
| 2) "POLYGON ((1 1, 1 200, 200 200, 200 1, 1 1))" | ||
| ``` | ||
|
|
||
| ### Point type |
There was a problem hiding this comment.
Searching with Co-ordinates
chayim
reviewed
Oct 17, 2023
chayim
reviewed
Oct 17, 2023
| @@ -38,6 +40,7 @@ internal void AddSchemaArgs(List<object> args) | |||
| { | |||
| FieldType.Text => "TEXT", | |||
| FieldType.Geo => "GEO", | |||
| FieldType.GeoShape => "GEOSHAPE", | |||
chayim
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188