Skip to content

Conversation

valkirilov
Copy link
Member

@valkirilov valkirilov commented Oct 9, 2025

Description

Differentiate the executed commands telemetry by their type (Workbench/Search).
Currently, when running commands from the Search page, you see logged telemetry related to the Workbench page.

Before After
image 2025-10-09_10-27

How it was tested

  1. Open Redis Insight
  2. Go to Databases and open a connection to an existing database instance, or create a new one
  3. Go to the Search tab from the main navbar
  4. Type in a query in the editor, like FT._LIST, and execute it via the “Run” button

There should be telemetry events related to Vector Search only.

2025-10-09_10-27

Notes

Update other telemetry events as well

The same logic applies to a few more custom telemetry events that we collect, so the same change applies to them as well.

Before After
2025-10-09_13-27 2025-10-09_13-31

Workbench is still operational

It still works fine from the Workbench page as well.

2025-10-09_10-28

@valkirilov valkirilov self-assigned this Oct 9, 2025
@valkirilov valkirilov changed the title fix(be): RI-7496 Diff executed commands telemetry by their type (Workbench/Search) Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13856/15006
🟡 Branches 74.13% 4183/5643
🟢 Functions 85.82% 2131/2483
🟢 Lines 92.13% 13245/14376

Test suite run success

2956 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from 54c328b

@valkirilov valkirilov force-pushed the be/bugfix/RI-7496_commands-telemetry branch from 6cff39d to 54c328b Compare October 9, 2025 10:55
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟢 Statements 81.54% 16238/19914
🟡 Branches 64.35% 7306/11353
🟡 Functions 70.31% 2272/3231
🟢 Lines 81.17% 15276/18819

@valkirilov valkirilov marked this pull request as ready for review October 9, 2025 11:11
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@valkirilov valkirilov merged commit 1de80eb into main Oct 10, 2025
32 checks passed
@valkirilov valkirilov deleted the be/bugfix/RI-7496_commands-telemetry branch October 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants