Add SCANDUMP and LOADCHUNK for bf and cf #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Aug 9, 2023
probabilistic.go
Outdated
| @@ -165,6 +169,79 @@ func (c cmdable) BFExists(ctx context.Context, key string, element interface{}) | |||
| return cmd | |||
| } | |||
|
|
|||
| func (c cmdable) BFLoadChunk(ctx context.Context, key string, iterator int64, data interface{}) *StatusCmd { | |||
| args := []interface{}{"bf.loadchunk", key, iterator, data} | |||
There was a problem hiding this comment.
Given history (and nothing else) commands really should be all in CAPS everywhere. Yes, we're not doing that currently, but no time like the present.
chayim
reviewed
Aug 9, 2023
chayim
reviewed
Aug 9, 2023
chayim
suggested changes
Aug 9, 2023
ofekshenawa
force-pushed
the
bloom-extra
branch
from
86aec28
to
bde4fdd
Compare
chayim
approved these changes
Aug 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.