Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the suffix for probablistic commands acceptings arguments to WithArgs from Args #2701

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

@chayim
Copy link
Contributor

chayim commented Sep 11, 2023

Given #2695 I think it may actually be fair to version this as 9.1.1 rather than 9.2.0. I'd argue that with the interface not being public (and for 3 weeks) I can recount what I said.

Yes, the functions themselves are renamed.

@peczenyj since you've provided the first/only feedback about support here.. WDYT?

@chayim
Copy link
Contributor

chayim commented Sep 11, 2023

@ofekshenawa note this is approved. The only question is around versions. If we release today and don't have input, I'll lean into 9.2.0. I'll poke @uglide .

Also can you add a description or cross-link as to why? I'd like to help others in the future.

@chayim chayim changed the title Rename probablistic commands with args Changing the suffix for probablistic commands acceptings arguments to WithArgs from Args Sep 11, 2023
@peczenyj
Copy link
Contributor

@chayim LGTM

my point on the other PR was to make the interface probabilistic public to be easier find such methods on the UniversalClient internet via godoc and package doc in web.

This PR sounds good to me

@ofekshenawa ofekshenawa merged commit 33edd3d into master Sep 20, 2023
7 checks passed
@ofekshenawa ofekshenawa deleted the os-rename-args-commands branch June 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants