Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4232 stream code examples #3128

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Sep 18, 2024

Go versions of the examples in this page.

Note: it's difficult to make the output from the stream commands work well with Go testable examples because of the nondeterministic timestamps. I've tried to work around this by explicitly setting the entry IDs to match the ones from the CLI example where possible. However, for the examples that show XAdd without setting the IDs, I've just put the fmt.Println() statements inside comments to prevent the output being tested. Doing this also means that some return values from the examples are unused, so I've added an UNUSED() function to allow the examples to compile. If there's a better approach to this then please let me know :-)

Also, because I needed to set the IDs, I placed several examples together in the same function in a few places (ie, to avoid making the file huge with loads of XAdd calls at the start of each example function). This displays OK in the doc page, but let me know if it's a problem from a coding/testing point of view.

@andy-stark-redis andy-stark-redis marked this pull request as ready for review September 18, 2024 10:55
@vladvildanov vladvildanov merged commit 1ed936e into redis:master Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants