Remove direct read from TLS underlying conn #3138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3137.
This essentially reverts 0858ed2, to avoid corrupting TLS sessions by directly reading from the underlying
net.Conn
. This is blocking upgrades to> 9.5.2
if using TLS.conn_check.go
is quite different on the v9.6 branch (it changed here), should I open another PR to fix that as well?