Skip to content

Conversation

PavelPashov
Copy link
Contributor

No description provided.

@PavelPashov PavelPashov changed the title Add scenario tests v5 test: add scenario tests v5 Sep 29, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive scenario tests v5 for Redis Cluster functionality, focusing on sharded pub/sub operations with fault injection capabilities. The implementation provides utilities for configuration management, message tracking, fault injection, and command execution in test environments.

  • Introduces test utilities for Redis cluster configuration and client management
  • Implements fault injection capabilities for testing resilience scenarios
  • Adds comprehensive sharded pub/sub scenario tests with failover testing

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/scenario/utils/test.util.ts Core utilities for test configuration, Redis client creation, and test data
test/scenario/utils/message-tracker.ts Message tracking utility for monitoring pub/sub message statistics
test/scenario/utils/fault-injector.ts HTTP client for triggering and monitoring fault injection actions
test/scenario/utils/command-runner.ts Test command execution utility for continuous message publishing
test/scenario/sharded-pub-sub.test.ts E2E scenario tests for sharded pub/sub with fault injection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


// All other channels should have received messages
const stillSubscribedChannels = CHANNELS.filter(
(channel) => !unsubscribeChannels.includes(channel as any)
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using as any type assertion defeats TypeScript's type safety. Since both arrays contain strings, this cast is unnecessary and should be removed.

Suggested change
(channel) => !unsubscribeChannels.includes(channel as any)
(channel) => !unsubscribeChannels.includes(channel)

Copilot uses AI. Check for mistakes.

@PavelPashov PavelPashov force-pushed the feat/add-scenario-tests branch from 973245b to 44e9f8c Compare September 29, 2025 14:40
@PavelPashov PavelPashov force-pushed the feat/add-scenario-tests branch 5 times, most recently from ac12946 to 91b4fdc Compare October 1, 2025 15:10
@PavelPashov PavelPashov force-pushed the feat/add-scenario-tests branch from 91b4fdc to 33773fb Compare October 2, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant