Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server addressed the issues of empty list returned for missing keys #2899

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Server addressed the issues of empty list returned for missing keys #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5664939
Server addressed the issues of empty list returned for missing keys
tishun Jun 19, 2024
e2e2638
Refresh the template to include isntrustion how to format the code
tishun Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Make sure that:

- [ ] You have read the [contribution guidelines](https://github.com/lettuce-io/lettuce-core/blob/main/.github/CONTRIBUTING.md).
- [ ] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
- [ ] You use the code formatters provided [here](https://github.com/lettuce-io/lettuce-core/blob/main/formatting.xml) and have them applied to your changes. Don’t submit any formatting related changes.
- [ ] You applied code formatting rules using the `mvn formatter:format` target. Don’t submit any formatting related changes.
- [ ] You submit test cases (unit or integration tests) that back your changes.

<!--
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/io/lettuce/core/commands/HashCommandIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ void hexpire() {
assertThat(redis.hexpire(MY_KEY, 0, MY_FIELD)).containsExactly(2L);
assertThat(redis.hset(MY_KEY, MY_FIELD, MY_VALUE)).isTrue();
assertThat(redis.hexpire(MY_KEY, 1, MY_FIELD, MY_SECOND_FIELD)).containsExactly(1L, -2L);
assertThat(redis.hexpire("invalidKey", 1, MY_FIELD)).isEmpty();
assertThat(redis.hexpire("invalidKey", 1, MY_FIELD)).containsExactly(-2L);

await().until(() -> redis.hget(MY_KEY, MY_FIELD) == null);
}
Expand All @@ -584,7 +584,7 @@ void hexpireat() {
assertThat(redis.hexpireat(MY_KEY, Instant.now().minusSeconds(1), MY_FIELD)).containsExactly(2L);
assertThat(redis.hset(MY_KEY, MY_FIELD, MY_VALUE)).isTrue();
assertThat(redis.hexpireat(MY_KEY, Instant.now().plusSeconds(1), MY_FIELD)).containsExactly(1L);
assertThat(redis.hexpireat("invalidKey", Instant.now().plusSeconds(1), MY_FIELD)).isEmpty();
assertThat(redis.hexpireat("invalidKey", Instant.now().plusSeconds(1), MY_FIELD)).containsExactly(-2L);

await().until(() -> redis.hget(MY_KEY, MY_FIELD) == null);
}
Expand All @@ -609,7 +609,7 @@ void hexpiretime() {
@Test
@EnabledOnCommand("HPERSIST")
void hpersist() {
assertThat(redis.hpersist(MY_KEY, MY_FIELD)).isEmpty();
assertThat(redis.hpersist(MY_KEY, MY_FIELD)).containsExactly(-2L);

assertThat(redis.hset(MY_KEY, MY_FIELD, MY_VALUE)).isTrue();
assertThat(redis.hpersist(MY_KEY, MY_FIELD)).containsExactly(-1L);
Expand Down