Add defensive copy for Futures allOf() method #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied provided formatter again! Could you re-run the test please? Thank you in advance. |
You need to fetch the fix from #2949 |
Closes redis#2935
jinkshower
force-pushed
the
add-defensive-copy
branch
from
42ecd23
to
883d7cd
Compare
thachlp
reviewed
Aug 11, 2024
| @@ -32,10 +32,11 @@ public static CompletableFuture<Void> allOf(Collection<? extends CompletionStage | |||
|
|
|||
| LettuceAssert.notNull(stages, "Futures must not be null"); | |||
|
|
|||
| CompletableFuture[] futures = new CompletableFuture[stages.size()]; | |||
| CompletionStage[] copies = stages.toArray(new CompletionStage[0]); | |||
| CompletableFuture[] futures = new CompletableFuture[copies.length]; | |||
|
|
|||
There was a problem hiding this comment.
Why need to create a copy array if you only need to get the size?
There was a problem hiding this comment.
the issue stated that this method throws ArrayIndexOutOfBoundsException. @tishun mentioned in #2935 that is probably because of the concurrent modification of the 'stages' and I agreed. So I created copy array and used in the for loop.
for (CompletionStage<?> stage : copies) { //use copies instead of stages
futures[index++] = stage.toCompletableFuture();
}
tishun
added
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2935
I've added defensive copy for the method so that external modification could not affect stages during iteration.
As for test, I can't come up with any better idea so just used two Threads each calling allOf() and modifying stages simultaneously.
Thank you.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.