Implement JSON raw return types #3478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggivo
approved these changes
Oct 23, 2025
Comment on lines
+175
to
+186
| CommandArgs<K, V> args = new CommandArgs<>(codec).addKey(key); | ||
|
|
||
| if (jsonPath != null) { | ||
| if (index != -1) { | ||
| // OPTIONAL as per API | ||
| args.add(jsonPath.toString()); | ||
| args.add(index); | ||
| } else if (!jsonPath.isRootPath()) { | ||
| // OPTIONAL as per API | ||
| args.add(jsonPath.toString()); | ||
| } | ||
| } |
There was a problem hiding this comment.
(nit) : Repeats the code in the overloaded method. We can extract it in a helper method to avoid code duplication & eventually getting methods out of sync
Comment on lines
+243
to
+257
| CommandArgs<K, V> args = new CommandArgs<>(codec).addKey(key); | ||
|
|
||
| if (options != null) { | ||
| // OPTIONAL as per API | ||
| options.build(args); | ||
| } | ||
|
|
||
| if (jsonPaths != null) { | ||
| // OPTIONAL as per API | ||
| for (JsonPath jsonPath : jsonPaths) { | ||
| if (jsonPath != null) { | ||
| args.add(jsonPath.toString()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
(nit) : Repeats the code in the overloaded method. We can extract it in a helper method to avoid code duplication & eventually getting methods out of sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements raw return types for JSON commands
See #3431