Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info docs with two buffer limit metrics. #2520

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

CharlesChen888
Copy link
Contributor

In redis/redis#12476 two new info merics are added: client_query_buffer_limit_reached and client_output_buffer_limit_reached.

Also correct the info of reply_buffer_shrinks and reply_buffer_expands.

@netlify
Copy link

netlify bot commented Aug 17, 2023

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3e220e3

@CharlesChen888
Copy link
Contributor Author

Got some spell check errors which are irrelevant to my changes ...

Error: docs/data-types/geospatial.md
    25:21-25:33  warning  `geo_tutorial` is misspelt         retext-spell           retext-spell
    25:34-25:40  warning  `geoadd` is misspelt               retext-spell           retext-spell
    26:10-26:24  warning  `bikes:rentable` is misspelt       retext-spell           retext-spell
     28:8-28:22  warning  `bikes:rentable` is misspelt       retext-spell           retext-spell
     30:6-30:20  warning  `bikes:rentable` is misspelt       retext-spell           retext-spell
    35:21-35:33  warning  `geo_tutorial` is misspelt         retext-spell           retext-spell
    35:34-35:43  warning  `geosearch` is misspelt            retext-spell           retext-spell
    36:[13](https://github.com/redis/redis-doc/actions/runs/5885804109/job/15962757838?pr=2520#step:4:14)-36:27  warning  `bikes:rentable` is misspelt       retext-spell           retext-spell

docs/data-types/lists.md
    73:34-73:43  warning  Expected `LEFT` once, not twice    retext-repeated-words  retext-repeated-words

docs/data-types/sets.md
     31:8-31:27  warning  `bikes:racing:france` is misspelt  retext-spell           retext-spell
     33:6-33:[25](https://github.com/redis/redis-doc/actions/runs/5885804109/job/15962757838?pr=2520#step:4:26)  warning  `bikes:racing:france` is misspelt  retext-spell           retext-spell
......

commands/info.md Outdated
@@ -300,8 +300,10 @@ Here is the meaning of all fields in the **stats** section:
* `total_writes_processed`: Total number of write events processed
* `io_threaded_reads_processed`: Number of read events processed by the main and I/O threads
* `io_threaded_writes_processed`: Number of write events processed by the main and I/O threads
* `stat_reply_buffer_shrinks`: Total number of output buffer shrinks
* `stat_reply_buffer_expands`: Total number of output buffer expands
* `client_query_buffer_limit_disconnections`: Total number of clients reached query buffer length limit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about "Total number of disconnections due to the client reached query buffer limit" and "Total number of disconnections due to the client reached output buffer limit"

I would like to emphasize the "disconnection".

@soloestoy soloestoy changed the title Update info docs with two new metrics. Correct two metric names. Update info docs with two buffer limit metrics. Jan 29, 2024
@soloestoy soloestoy merged commit f0fc05d into redis:master Jan 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants