Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hyperloglogs.md with hugo short codes #2548

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update hyperloglogs.md with hugo short codes #2548

merged 3 commits into from
Oct 6, 2023

Conversation

sav-norem
Copy link
Contributor

added a pfmerge example - condensed to one more robust example

@sav-norem
Update hyperloglogs.md with hugo short codes
783763b 
added a pfmerge example - condensed to one more robust example
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 93e8a50

@sav-norem
Copy link
Contributor Author

@dwdougherty hyperloglog!

dwdougherty
dwdougherty requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one rewording change. Otherwise good. If you agree with my change and you merge it to this PR, I'll do a test build before approving the merge to master. As ever, I don't have permission to formally approve or merge.

@sav-norem @dwdougherty
Update docs/data-types/probabilistic/hyperloglogs.md
f7c7152 
address feedback on PR

Co-authored-by: David Dougherty <[email protected]>
dwdougherty
dwdougherty approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this PR in my test environment and all the modified examples are rendering correctly.

@sav-norem
Copy link
Contributor Author

@dmaier-redislabs David D checked it out and it's ready to go!

@dwdougherty dwdougherty added the to-be-merged should probably be merged soon label Oct 4, 2023
@dmaier-redislabs dmaier-redislabs merged commit 970297c into redis:master Oct 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

Assignees
No one assigned
Labels
to-be-merged should probably be merged soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sav-norem @dwdougherty @dmaier-redislabs