Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TwitterClient.stopFilteredStream() variant with a timeout #406

Merged

Conversation

takeshitakenji
Copy link
Contributor

Added TwitterClient.stopFilteredStream() variant with a timeout to implement #393 .

@redouane59
Copy link
Owner

Nice, thanks for this PR ! It will be added on the next release :)

@redouane59 redouane59 mentioned this pull request Oct 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@redouane59 redouane59 merged commit c2e9895 into redouane59:develop Oct 7, 2022
redouane59 added a commit that referenced this pull request Oct 8, 2022
* update version

* Use try with resources, improve logging (#401)

* Use try with resources, improve logging

* Use try with resources, improve logging

* Replace concatenation with placeholders in logging (#402)

* Extract object mapper, optimize user enrichment (#403)

* Extract ObjectMapper to JsonHelper

* Optimize users enrichment

* Add Variant media field (#404)

* Add Variant media field

* Add assertion

* Added TwitterClient.stopFilteredStream() variant with a timeout. (#406)

Co-authored-by: Nick <[email protected]>
Co-authored-by: takeshitakenji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants