feat(agent): system prompt templating and global instruction propagation#130
Draft
FelipeSuarez16 wants to merge 4 commits into
Draft
feat(agent): system prompt templating and global instruction propagation#130FelipeSuarez16 wants to merge 4 commits into
FelipeSuarez16 wants to merge 4 commits into
Conversation
This change replaces the previous regex-based templating with a flexible InstructionProvider callback. This delegates prompt generation to the user, simplifying the SDK and avoiding hardcoded templating engines. It also introduces WithGlobalInstruction for static directives and supports context-based instruction propagation through the invocation tree. Key changes: - Add WithInstructionProvider and InstructionProvider type. - Add WithGlobalInstruction functional option. - Refactor resolveSystemPrompt to handle fallback and merging. - Remove rejected regex templating engine. - Add comprehensive tests for fallback and merging logic.
a797d7d to
69a2bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements dynamic system prompt templating and a mechanism for propagating global instructions through agent trees, addressing issue #99.
Key Features
Dynamic Prompt Templating:
Global Instructions Propagation:
Security & Robustness:
Standards & Documentation:
Implementation Details
Verification
Fixes #99