Kapa local #238
Closed
Kapa local #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeSCahill
reviewed
Jan 6, 2025
| @@ -66,7 +66,7 @@ module.exports = (src, dest, preview) => () => { | |||
| // NOTE concat already uses stat from newest combined file | |||
| .pipe(concat('js/site.js')), | |||
| vfs | |||
| .src('js/vendor/*([^.])?(.bundle).js', { ...opts, read: false }) | |||
| .src(['js/vendor/*([^.])?(.bundle).js', '!js/vendor/kapa-widget.bundle.js'], { ...opts, read: false }) | |||
There was a problem hiding this comment.
Why did we need this change?
Did you try using the method we used for the other vendor scripts that don't get bundled? For example prism or algolia?
There was a problem hiding this comment.
if you remove .bundle from the script name, it shouldn't require this special treatment,
| 'gulpfile.js', | ||
| 'gulp.d/**/*.js', | ||
| `${srcDir}/{helpers,js}/**/*.js`, | ||
| `!${srcDir}/js/vendor/kapa-widget.bundle.js`, |
There was a problem hiding this comment.
Not sure why we need this part.
|
Closing as Kapa doesn't seem to support local bundles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Kapa locally