Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update role binding #174

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update role binding #174

merged 1 commit into from
Jul 23, 2024

Conversation

koikonom
Copy link

After changing the way we remove finalizers we also need to update the permissions.

@koikonom koikonom requested a review from 0xdiba July 23, 2024 12:38
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@chrisseto
Copy link
Contributor

These permissions should be added as a marker to the controller that requires them. Running ./task k8s:generate-manifests will revert this change.

@koikonom koikonom force-pushed the bug/update_role_patch_finalizers branch from 752e987 to 3128a74 Compare July 23, 2024 14:58
After changing the way we remove finalizers we also need to update the
permissions.
@koikonom koikonom force-pushed the bug/update_role_patch_finalizers branch from 3128a74 to 9c2d754 Compare July 23, 2024 15:30
@chrisseto
Copy link
Contributor

For posterity: The /finalizers appears to be a valid albeit under documented permission that is not a "true" subresource like status. Certmanager has a reference in their manifests to this page which seems to indicate that /finalizers acts more like a permission for ownerreferences than anything else.

A quick grep of the Kubernetes code base doesn't offer many hints.

@chrisseto
Copy link
Contributor

I'm going to merge this and ignore the failures from k8s-operator. Kuttl tests have been quite flakey as of late and this is a fairly safe change. See also #173

@chrisseto chrisseto merged commit 47d5475 into main Jul 23, 2024
3 of 4 checks passed
@chrisseto chrisseto deleted the bug/update_role_patch_finalizers branch July 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants