Helm nightly release #345

RafalKorepta · 2024-12-06T11:11:52Z

On top of #340

Successful run https://buildkite.com/redpanda/redpanda-operator/builds/3558

The OCI helm chart https://hub.docker.com/layers/redpandadata/redpanda-operator-nightly/v0.0.0-20241205gitc2a1d6d-helm-chart-helm-chart/images/sha256-ff6903565a4a78b854f6bae3e722ce9d3d56997586465122ddc982d197e94b78?context=explore

Buildkite scheduled build settings

TODO

It seems that Docker Hub repository don't allow multi architecture containers, when I pushed helm chart to redpanda-operator-nightly repository.

https://forums.docker.com/t/tag-overlap-in-oci-artifacts/131453
https://redpandadata.slack.com/archives/C06MCRY75U7/p1733484680969879

K8S-440

chrisseto · 2024-12-06T14:30:44Z

.gitignore

@@ -36,3 +36,9 @@ operator/tests/e2e-v2-helm/

 # Go releaser artifacts
 dist/
+
+# Dep Chart Lock file
+Chart.lock


Didn't we determine that we need Chart.lock to be checked in? https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/Chart.lock

Good question. I'm going back and fourth with this. Our tests in redpanda repo requires Chart.lock to have stable input. I didn't want operator helm chart lock as I feel like it's not required. Never the less if .helmignore will exclude Chart.lock I can commit Chart.lock.

We don't currently have Chart.lock in our .helmignore either. That also caused problems.

charts/connectors/Chart.yaml

operator/go.mod

chrisseto · 2024-12-06T14:45:20Z

taskfiles/k8s.yml

+      - helm registry login registry-1.docker.io -u {{.DOCKERHUB_USER}} --password {{.DOCKERHUB_TOKEN}}
+      - helm dep update charts/operator
+      # To change name of the operator helm chart malformer program is executed
+      - go run ./nightly-malformer/...


It looks like you could accomplish this by just running helm package --version $TAG_NAME

The most important change is changing the Chart name just to match the https://hub.docker.com/r/redpandadata/redpanda-operator-nightly docker hub repository. That way we can host helm chart and containers under one repository.

Not to be too crotchety but it looks like this could also be handled by a tiny bit of scripting with tar and yq. Doing so would be more easily reusable for other charts and not dependent on go loading Chart.yaml.

taskfiles/k8s.yml

chrisseto · 2024-12-06T14:50:27Z

taskfiles/k8s.yml

+      - helm dep update charts/operator
+      # To change name of the operator helm chart malformer program is executed
+      - go run ./nightly-malformer/...
+      - helm package charts/operator


nit: To avoid littering the repo when running this task, it'd be preferable to output the build to either a tempdir or the dist directory which is git ignored.

Agree. will adjust.

My personal goal would be to use go program to load chart and the push it to docker hub. I'm using helm cli just for the quick turnaround.

I think we might be able to fix that with some help from dev prod? If we can update the k8s-builders to use the containerd image store by default multi platform builds will "just work"¹.

Footnotes

https://docs.docker.com/engine/storage/containerd/ ↩

…tion

chrisseto · 2024-12-12T15:04:21Z

.gitignore

@@ -36,3 +36,9 @@ operator/tests/e2e-v2-helm/

 # Go releaser artifacts
 dist/
+
+# Dep Chart Lock file
+Chart.lock


We don't currently have Chart.lock in our .helmignore either. That also caused problems.

chrisseto · 2024-12-12T15:06:23Z

charts/console/Chart.yaml

@@ -36,7 +36,7 @@ kubeVersion: ">= 1.25.0-0"

 icon: https://images.ctfassets.net/paqvtpyf8rwu/3cYHw5UzhXCbKuR24GDFGO/73fb682e6157d11c10d5b2b5da1d5af0/skate-stand-panda.svg
 sources:
-  - https://github.com/redpanda-data/helm-charts
+  - https://github.com/redpanda-data/redpanda-operator/charts


These links don't resolve as they need the ref set. https://github.com/redpanda-data/redpanda-operator/tree/main/charts

Should we go ahead and link to the specific folder or the chart as well? e.g. https://github.com/redpanda-data/redpanda-operator/tree/main/charts/console

chrisseto · 2024-12-12T15:08:01Z

charts/operator/chart.go

-func ChartMeta() helmette.Chart {
-	return chartMeta
-}
+// render is the entrypoint to both the go and helm versions of the redpanda


I'd prefer to not merge changes to the charts until we have CI running generation and unit tests for them. It's too easy for something to accidentally slip in and not get caught until MUCH later.

chrisseto · 2024-12-12T15:23:41Z

taskfiles/k8s.yml

+      - helm registry login registry-1.docker.io -u {{.DOCKERHUB_USER}} --password {{.DOCKERHUB_TOKEN}}
+      - helm dep update charts/operator
+      # To change name of the operator helm chart malformer program is executed
+      - go run ./nightly-malformer/...


Not to be too crotchety but it looks like this could also be handled by a tiny bit of scripting with tar and yq. Doing so would be more easily reusable for other charts and not dependent on go loading Chart.yaml.

chrisseto · 2024-12-12T15:25:32Z

operator/pkg/resources/statefulset.go

@@ -501,6 +501,7 @@ func (r *StatefulSetResource) obj(
 						{
 							Name:            configuratorContainerName,
 							Image:           r.fullConfiguratorImage(),
+							Command:         []string{"/redpanda-operator", "configure"},


I think this change has leaked into the wrong commit?

chrisseto · 2024-12-12T15:28:48Z

taskfiles/k8s.yml

@@ -70,25 +70,26 @@ tasks:
      - |
        go test -v ./... -coverprofile cover.out -timeout 20m

-  build-operator-images:
+  build-container-image:


Are these changes related to the nightly helm release or the removal of the vectorized repository? If it's the nightly helm release, could you explain why this change is needed? It looks to primarily be a refactor to me?

RafalKorepta requested review from chrisseto and andrewstucki as code owners December 6, 2024 11:11

RafalKorepta force-pushed the rk/k8s-440/helm-nightly-release branch 5 times, most recently from 1abe2b1 to 86d064d Compare December 6, 2024 14:24

chrisseto reviewed Dec 6, 2024

View reviewed changes

RafalKorepta force-pushed the rk/k8s-440/helm-nightly-release branch 2 times, most recently from de6a54f to 8af6cca Compare December 9, 2024 19:29

RafalKorepta mentioned this pull request Dec 10, 2024

Switch redpanda-operator container image instead of configurator redpanda-data/helm-charts#1620

Open

RafalKorepta added 5 commits December 12, 2024 11:31

Migrate operator to new render function along with gotohelm Load func…

8dc66a6

…tion

Change the helm charts metadata source to redpanda-operator repo

cb007c7

Ignore helm chart specific file and depedencies

b753eb3

Add helm release to nightly release

acaca66

Drop vectorized/configurator

5f19af1

RafalKorepta force-pushed the rk/k8s-440/helm-nightly-release branch from 8af6cca to 5f19af1 Compare December 12, 2024 10:39

chrisseto reviewed Dec 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm nightly release #345

Helm nightly release #345

RafalKorepta commented Dec 6, 2024 •

edited

Loading

chrisseto Dec 6, 2024

RafalKorepta Dec 6, 2024

chrisseto Dec 12, 2024

chrisseto Dec 6, 2024

RafalKorepta Dec 6, 2024

chrisseto Dec 12, 2024

chrisseto Dec 6, 2024

RafalKorepta Dec 6, 2024

chrisseto Dec 9, 2024

chrisseto Dec 12, 2024

chrisseto Dec 12, 2024

chrisseto Dec 12, 2024

chrisseto Dec 12, 2024

chrisseto Dec 12, 2024

chrisseto Dec 12, 2024

Helm nightly release #345

Are you sure you want to change the base?

Helm nightly release #345

Conversation

RafalKorepta commented Dec 6, 2024 • edited Loading

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Footnotes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RafalKorepta commented Dec 6, 2024 •

edited

Loading