Synchronize operator source code with kubebuilder scafolding project #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, any progress on this? The operator installation is broken because the gcr.io/kubebuilder/kube-rbac-proxy image has been removed from the repository and now I can't install the operator at all. I think this fixes that. |
|
Hey @BryanDollery I'm working on finishing it, but it needs more work as we need to shuffle go modules a bit. As I mentioned in other GH issue the image is still available. |
RafalKorepta
force-pushed
the
rk/K8S-459/deprecate-rbac-proxy
branch
4 times, most recently
from
f4f38c6 to
659dc9a
Compare
The task ci:test:acceptance target is creating kind cluster. The kind cluster created in test:acceptance inside Taskfile.yml is redundant.
RafalKorepta
force-pushed
the
rk/K8S-459/deprecate-rbac-proxy
branch
2 times, most recently
from
27ef75e to
25e4fe2
Compare
RafalKorepta
force-pushed
the
rk/K8S-459/deprecate-rbac-proxy
branch
from
25e4fe2 to
d61d4a2
Compare
Clean the kustomization. Remove unused kustomization `default-with-metrics`. Remove `kube-rbac-proxy` container from kustomization and helm chart.
RafalKorepta
force-pushed
the
rk/K8S-459/deprecate-rbac-proxy
branch
from
d61d4a2 to
c405594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #422
Clean the kustomization.
Remove unused kustomization
default-with-metrics.Remove
kube-rbac-proxycontainer from kustomization and helm chart.K8S-459
kubernetes-sigs/kubebuilder#3907