Conversation
alenkacz
force-pushed
the
av/read-external-secrets
branch
7 times, most recently
from
49c68d0 to
8db21c8
Compare
alenkacz
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
chrisseto
approved these changes
Mar 27, 2025
Contributor
chrisseto
left a comment
chrisseto
left a comment
There was a problem hiding this comment.
Couple nits, nothing blocking.
Rafal's PR needs a few updates before it gets merged so let's hold off until then if possible.
alenkacz
force-pushed
the
av/read-external-secrets
branch
4 times, most recently
from
3567e4e to
50bd77b
Compare
| config.SetAdditionalRedpandaProperty("a", "b") | ||
| require.NoError(t, config.FinalizeToTemplate()) | ||
| concreteCfg, err := config.ConcreteConfiguration(context.TODO(), nil, "", nil) | ||
| concreteCfg, err := config.ConcreteConfiguration(context.TODO(), nil, nil, "", nil) |
Contributor
There was a problem hiding this comment.
NIT: This change should be applied to the next commit.
Contributor
Author
There was a problem hiding this comment.
I believe you guys squash anyway so should be fine :)
alenkacz
force-pushed
the
av/read-external-secrets
branch
from
50bd77b to
a13aeb4
Compare
alenkacz
force-pushed
the
av/read-external-secrets
branch
from
a13aeb4 to
7bb77ad
Compare
Contributor
|
In order to release your feature please use backport cli to create backport PRs https://github.com/redpanda-data/redpanda-operator/blob/main/CONTRIBUTING.md#backporting |
andrewstucki
pushed a commit
that referenced
this pull request
Apr 2, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d) # Conflicts: # operator/cmd/run/run.go # operator/go.mod # operator/go.sum
andrewstucki
pushed a commit
that referenced
this pull request
Apr 2, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d) # Conflicts: # licenses/third_party.md # operator/cmd/run/run.go # operator/go.mod # operator/go.sum
andrewstucki
pushed a commit
that referenced
this pull request
Apr 2, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d) # Conflicts: # licenses/third_party.md # operator/cmd/run/run.go # operator/go.mod # operator/go.sum
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jan-g
pushed a commit
that referenced
this pull request
Apr 4, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d) # Conflicts: # operator/cmd/run/run.go # operator/go.mod # operator/go.sum
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 15, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d)
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 19, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d)
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 22, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d)
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 23, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d)
RafalKorepta
pushed a commit
that referenced
this pull request
Apr 23, 2025
* gomod: add newest pkg dependency * add cloud secrets expansion into v1 operator * add cloud secrets expansion into v1 configurator (cherry picked from commit 575887d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds external secret resolution to v1 operator.