[v23.2.x] only run PR checks when needed #13937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
requested changes
Oct 5, 2023
| @@ -18,8 +18,7 @@ on: | |||
| - 'v*' | |||
| paths: | |||
| - .github/workflows/redpanda-migration-build.yml | |||
| - 'src/go/cluster-to-redpanda-migration/**' | |||
| - 'src/go/k8s/**' | |||
| - src/go/cluster-to-redpanda-migration | |||
There was a problem hiding this comment.
this will undo the fix to the pattern for the paths option. It'll be better to leave this change out and only leave the removal of the helm-chart-release.yml workflow file
There was a problem hiding this comment.
oops, thanks for catching that.
There was a problem hiding this comment.
Not leaving out the change entirely because there's no reason to test the migration tool when there are changes to src/go/k8s.
joejulian
force-pushed
the
backport_13186/v23.2.x
branch
from
7c6e43c to
d84bdf7
Compare
|
The failing test is unrelated to this change. |
ivotron
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart doesn't live here anymore, no need to have that workflow.
Don't run the other workflows for PRs that don't modify their code.
Backport of PR #13186
Backports Required
Release Notes