[DNM] [v23.2.x] cmake tweaks for vtools trunk-based development #19886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Jimenez <[email protected]> (cherry picked from commit 58ab041)
The `v_` prefixed was dropped Signed-off-by: Ivo Jimenez <[email protected]> (cherry picked from commit b93d1ba)
Signed-off-by: Noah Watkins <[email protected]> (cherry picked from commit ad49bdb)
Signed-off-by: Noah Watkins <[email protected]> (cherry picked from commit 0ddf160)
Signed-off-by: Noah Watkins <[email protected]> (cherry picked from commit 2b73b5e)
ivotron
force-pushed
the
cmake-tweaks-for-vtools-trunkbased-23.2.x
branch
from
ff70601 to
15eddb5
Compare
savex
approved these changes
Jul 12, 2024
| @@ -133,15 +133,15 @@ def _find_addr2lines(self): | |||
| # Workstation: find our build directory by searching back from binary | |||
| path_parts = self.binary.split("/") | |||
| try: | |||
| vbuild = "/".join(path_parts[0:path_parts.index("vbuild") + 3]) | |||
| vbuild = "/".join(path_parts[0:path_parts.index("vbuild") + 5]) | |||
There was a problem hiding this comment.
nit: It would be good to have an example path here is a comment to help future generations.
| add_custom_target(${NAME}) | ||
| add_custom_command(TARGET ${NAME} | ||
| COMMAND env GOPATH=${GOPATH} ${CMAKE_GO_BINARY} build | ||
| string(REPLACE "-" "_" target_name ${NAME}) |
There was a problem hiding this comment.
nit: comments with example name updates and why would be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNM - used for testing
Backports Required
Release Notes