gha: increase commits cherry-picked in backport #23451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results from `gh api` will have multiple pages if too many. This is usually around 30 results for /commits. Using `--paginate` will retrieve all pages. Also, reduce git commit hash to 10 for brevity in the cherry-pick command.
dotnwat
reviewed
Sep 26, 2024
| @@ -117,7 +117,7 @@ jobs: | |||
| GITHUB_TOKEN: ${{ env.ACTIONS_BOT_TOKEN }} | |||
| id: backport_commits | |||
| run: | | |||
| backport_commits=$(gh api "repos/$TARGET_FULL_REPO/pulls/$BACKPORT_PR_NUMBER/commits" --jq .[].sha | paste -s -d ' ' -) | |||
| backport_commits=$(gh api "repos/$TARGET_FULL_REPO/pulls/$BACKPORT_PR_NUMBER/commits" --paginate --jq '.[].sha[0:10]') | |||
There was a problem hiding this comment.
wow nice catch.
do we know if any past backports were affected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/backportcommand will only cherry-pick the first 30 commits of the PR. This PR fixes that by cherry-picking all commits.Also, reduce commit sha from 40 chars to 10 chars for brevity in displaying cherry-pick command.
jira: PESDLC-2095
Backports Required
Release Notes