[CORE-7096] Hook admin API to debug bundle service#23557
Merged
michael-redpanda merged 6 commits intoredpanda-data:devfrom Oct 1, 2024
Merged
[CORE-7096] Hook admin API to debug bundle service#23557michael-redpanda merged 6 commits intoredpanda-data:devfrom
michael-redpanda merged 6 commits intoredpanda-data:devfrom
Conversation
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
CORE-7096-debug-bundle-handlers
branch
from
8cc89c5 to
399da5a
Compare
BenPope
requested review from
a team,
michael-redpanda and
pgellert
and removed request for
a team
Contributor
michael-redpanda
left a comment
michael-redpanda
left a comment
There was a problem hiding this comment.
looks nice! couple of nits/suggestions
Collaborator
|
new failures in https://buildkite.com/redpanda/redpanda/builds/55432#01924305-ecf6-46e6-807f-424356404985: new failures in https://buildkite.com/redpanda/redpanda/builds/55474#01924486-9afa-4697-9de7-dd86edcd1c07: |
Collaborator
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55432#01924306-89ef-45d4-9c89-d7992f69222c ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55432#01924306-89ec-4807-95e3-097541204e8f ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55537#01924876-bda7-494b-b4bc-5c099a03cbac ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55572#01924936-7203-4a93-ba25-9e9fc65399bb ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55572#01924936-720c-4b45-9ed1-9d0e2bf70adb |
pgellert
reviewed
Sep 30, 2024
BenPope
force-pushed
the
CORE-7096-debug-bundle-handlers
branch
from
3af4765 to
74279c6
Compare
Member
Author
|
CI Failures: |
Contributor
michael-redpanda
left a comment
michael-redpanda
left a comment
There was a problem hiding this comment.
just need the new fields in the parameters
BenPope
force-pushed
the
CORE-7096-debug-bundle-handlers
branch
from
74279c6 to
50b4479
Compare
BenPope
force-pushed
the
CORE-7096-debug-bundle-handlers
branch
from
50b4479 to
ea1579b
Compare
michael-redpanda
previously approved these changes
Oct 1, 2024
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
CORE-7096-debug-bundle-handlers
branch
from
ea1579b to
8d3c3d9
Compare
Member
Author
|
Changes in force-push
|
pgellert
approved these changes
Oct 1, 2024
michael-redpanda
approved these changes
Oct 1, 2024
michael-redpanda
added a commit
to michael-redpanda/redpanda
that referenced
this pull request
Oct 2, 2024
Thanks to some merge ordering schenangians, these tests started failing when redpanda-data#23557 merged after redpanda-data#23508. This change addresses the test bug by properly obtaining the configuration property and handling a situation when the debug bundle directory configuration is empty. Signed-off-by: Michael Boquard <michael@redpanda.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of CORE-7095
Implement:
GET /debug/bundle/file/{filename}DELETE /debug/bundle/file/{filename}Add ducktape tests for all endpoints:
POST /v1/debug/bundleGET /v1/debug/bundleDELETE /v1/debug/bundle/{jobid}GET /debug/bundle/file/{filename}(returnsnot_implemented)DELETE /debug/bundle/file/{filename}(returnsnot_implemented)Backports Required
Release Notes