datalake/coordinator: iron out RPC types #23707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
datalake-rpc-types
branch
from
aa92220 to
5fd7f69
Compare
Updates the coordinator RPC add_file to use translated_offset_range to represent groups of files. Each translated offset range will be analagous to the write of a single translation operation, as it corresponds to a single contiguous Kafka offset range. Also updates the fetch_lastest to just return the latest Kafka offset.
andrwng
force-pushed
the
datalake-rpc-types
branch
from
5fd7f69 to
80a5965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the coordinator RPC add_file to use translated_offset_range to represent groups of files. Each translated offset range will be analagous to the write of a single translation operation, as it corresponds to a single contiguous Kafka offset range.
Also updates the fetch_lastest to just return the latest Kafka offset.
Along the way, moved the ostream definitions out of the header, which contributed to a failure to build.
Also adds an hour field to the data_file type.
Backports Required
Release Notes