Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] kafka: Consumer group stale static member properties on rejoin #23731

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[v23.3.x] kafka: Consumer group stale static member properties on rejoin #23731

merged 2 commits into from
Oct 14, 2024

Conversation

IoannisRP
Copy link
Contributor

Backport of PR #23693

@IoannisRP IoannisRP added this to the v23.3.x-next milestone Oct 10, 2024
@IoannisRP IoannisRP added the kind/backport PRs targeting a stable branch label Oct 10, 2024
@IoannisRP IoannisRP requested review from BenPope and pgellert October 10, 2024 13:54
IoannisRP
IoannisRP commented Oct 10, 2024
View reviewed changes
src/v/kafka/server/group.cc Outdated
Comment on lines 966 to 1021
std::move(member), r.native_member_protocols());
std::move(member),
r.native_member_protocols(r),
r.client_id,
r.client_host,
r.data.session_timeout_ms,
r.data.rebalance_timeout_ms);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict due to "native_member_protocol" being a member function, before.
It is a free function in dev.

@IoannisRP IoannisRP marked this pull request as ready for review October 11, 2024 09:06
@IoannisRP
kafka: expand members updated by group::update_member
c927d21 
Up to now, group::update_member function would only update the
protocols of the group_member. The fields updated now include the
client id and host fields and the session and rebalance timeout
durations.

(cherry picked from commit e1bc0df)
@IoannisRP
kafka: Add ducktape test for updating a group static member
13753a3 
(cherry picked from commit 72365bb)
@IoannisRP IoannisRP force-pushed the vbotbuildovich/backport-23693-v23.3.x-148 branch from b7abeea to 13753a3 Compare October 11, 2024 10:34
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 11, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56343#01927b55-1bd4-4476-bc59-05594a7dc8dc
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56343#01927b60-0a4f-44a2-b5b4-8eb388f60a76

@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56343#01927b55-1bdb-4487-b858-abf2125f1d65:

"rptest.tests.cluster_config_test.ClusterConfigTest.test_valid_settings"

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#56343

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/cluster_config_test.py::ClusterConfigTest.test_valid_settings

@IoannisRP
Copy link
Contributor Author

IoannisRP commented Oct 11, 2024 •
edited by jira bot
Loading

CI Failure:

@michael-redpanda michael-redpanda merged commit e3694b4 into redpanda-data:v23.3.x Oct 14, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgellert pgellert pgellert approved these changes

@BenPope BenPope BenPope approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.x-next
Development

Successfully merging this pull request may close these issues.
5 participants
@IoannisRP @vbotbuildovich @BenPope @pgellert @michael-redpanda