Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archival: Disable cross-term compaction #24566

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Lazin
Copy link
Contributor

@Lazin Lazin commented Dec 13, 2024

Currently, the segment_collector can collect data from segments generated in different terms. The component is used to generate compacted reuploads. This commit fixes this by disabling the cross term segment collection.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

Currently, the segment_collector can collect data from segments
generated in different terms. The component is used to generate
compacted reuploads. This commit fixes this by disabling the cross term
segment collection.

Signed-off-by: Evgeny Lazin <[email protected]>
@Lazin Lazin requested a review from andrwng December 13, 2024 15:38
@Lazin Lazin requested a review from WillemKauf December 13, 2024 15:38
@WillemKauf
Copy link
Contributor

Currently, the segment_collector can collect data from segments generated in different terms.

Can you add some context as to why this is a problem/why this behavior needs changing/fixing?

@Lazin
Copy link
Contributor Author

Lazin commented Dec 13, 2024

@WillemKauf it's needed to handle OffsetForLeaderEpoch requests correctly. If we're merging two segments produced in two different terms we're loosing information about the term. In this case we can't reply to the request correctly.

Copy link
Contributor

@WillemKauf WillemKauf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the context as to why this is needed might be helpful in either the commit message or the comment above the function declaration, for posterity.

Nice test.

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#59728

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":false,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":false}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":false,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":true}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":true,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":false}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":true,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":true}

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#59728
test_id test_kind job_url test_status passed
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=False.mixed_versions=False.with_tiered_storage=False.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59728#0193c0f2-7195-46b8-9bf9-c04ad747bf08 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=False.mixed_versions=False.with_tiered_storage=True.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59728#0193c0f2-7195-46b8-9bf9-c04ad747bf08 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=False.with_tiered_storage=False.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59728#0193c0f2-7195-46b8-9bf9-c04ad747bf08 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=False.with_tiered_storage=True.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59728#0193c0f2-7195-46b8-9bf9-c04ad747bf08 FAIL 0/1
test_archival_service_rpfixture.test_archival_service_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/59728#0193c0ac-8b14-4759-b0b0-7e0ce61fc7d0 FAIL 0/2
test_archival_service_rpfixture.test_archival_service_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/59728#0193c0ac-8b15-4542-bf08-c8ce72305901 FAIL 0/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants