Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.3.x] datalake/metrics: miscellaneous improvements to lag metrics #24575

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24568

This is based on our experience debugging Brandon's perf setup.

- Changes the metric reporting to report lag only on leaders. This makes
  it easy to monitor the metric using an aggregate across all replicas
  without having to worry about the current leader.

- Fixed a bug where lag entry was not added to serde fields, adjusted
  the test coverage to catch this scenario, refactored the test slightly
  while I'm there.

(cherry picked from commit bef3254)
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Dec 14, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Dec 14, 2024
@bharathv bharathv enabled auto-merge December 15, 2024 01:28
@bharathv bharathv merged commit ac6cfbf into redpanda-data:v24.3.x Dec 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants