Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka/client: replace std::vector with chunked vector #24582

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

kafka/client: replace std::vector with chunked vector #24582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/kafka/client/client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ ss::future<produce_response::partition> client::produce_record_batch(
}

ss::future<produce_response> client::produce_records(
model::topic topic, std::vector<record_essence> records) {
model::topic topic, chunked_vector<record_essence> records) {
absl::node_hash_map<model::partition_id, storage::record_batch_builder>
partition_builders;

Expand Down
2 changes: 1 addition & 1 deletion src/v/kafka/client/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class client {
model::topic_partition tp, model::record_batch&& batch);

ss::future<produce_response>
produce_records(model::topic topic, std::vector<record_essence> batch);
produce_records(model::topic topic, chunked_vector<record_essence> batch);

ss::future<list_offsets_response> list_offsets(model::topic_partition tp);

Expand Down
2 changes: 1 addition & 1 deletion src/v/pandaproxy/json/requests/produce.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class produce_request_handler {

public:
using Ch = typename Encoding::Ch;
using rjson_parse_result = std::vector<kafka::client::record_essence>;
using rjson_parse_result = chunked_vector<kafka::client::record_essence>;
rjson_parse_result result;

explicit produce_request_handler(serialization_format fmt)
Expand Down
Loading