[v24.3.x] r/utils: fixed setting log start delta in snapshot #24628
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When topic partition is recovered from cloud data Raft protocol is seeded with special snapshot created during recovery. The snapshot may then be used to seed out of date followers. The snapshot content must be valid in terms of offsets and offset translator deltas. Previously the delta set in the snapshot created during recovery was set to 0. When this snapshot is delivered to the follower it will reset the follower offset translation state accordingly. This may lead to inconsistent deltas across replicas. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit e7ea155)
ztlpn
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24618