Abort translation using translation task abort source #24641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
fix-translator-stop
branch
from
15c305b to
84319b6
Compare
ztlpn
previously approved these changes
Dec 23, 2024
Partition data translation may take long time, passing in abort source to `datalake::record_multiplexer` will allow us to timely stop the translation when partition is stopping. The translation result would be discarded anyway as all cloud IO is already stopped. Signed-off-by: Michał Maślanka <[email protected]>
mmaslankaprv
force-pushed
the
fix-translator-stop
branch
from
84319b6 to
d32b389
Compare
ztlpn
approved these changes
Dec 23, 2024
|
/backport v24.3.x |
|
Failed to create a backport PR to v24.3.x branch. I tried: |
rockwotj
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partition data translation may take long time, passing in abort source to
datalake::record_multiplexerwill allow us to timely stop the translation when partition is stopping. The translation result would be discarded anyway as all cloud IO is already stopped.Backports Required
Release Notes