Use chunked_vector in append_entries_request
#24774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
2 times, most recently
from
0a6b045 to
f09f518
Compare
mmaslankaprv
changed the title
chunked_vector in append_entries_request
dotnwat
reviewed
Jan 14, 2025
|
kind of similar, this one is a follow up, getting rid of the reader abstraction from RPC request |
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
f09f518 to
ab3aca5
Compare
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
5 times, most recently
from
b87f750 to
6bb544f
Compare
CI test resultstest results on build#60953
test results on build#60965
test results on build#60987
test results on build#61037
|
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
6bb544f to
1867fce
Compare
|
linter problem |
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
1867fce to
289a56f
Compare
Retry command for Build#60965please wait until all jobs are finished before running the slash command |
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
289a56f to
905d990
Compare
ztlpn
reviewed
Jan 21, 2025
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
0f491c5 to
7149cfc
Compare
In order to match the real life scenario changed raft fixture to use serde wrapper for append entries request as wrapper is used in normal operations. Signed-off-by: Michał Maślanka <[email protected]>
`model::record_batch_reader` was not the best abstraction to represent the batches in `append_entries_request`. Number of batches contained in the request is known upfront and they are always materialized in memory. Therefore it is more convenient and easier to store batches as a plain `chunked_vector` instead of the reader. Signed-off-by: Michał Maślanka <[email protected]>
Signed-off-by: Michał Maślanka <[email protected]>
mmaslankaprv
force-pushed
the
aer-chunked-vector
branch
from
7149cfc to
6e31742
Compare
ztlpn
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model::record_batch_readerwas not the best abstraction to representthe batches in
append_entries_request. Number of batches contained inthe request is known upfront and they are always materialized in memory.
Therefore it is more convenient and easier to store batches as a plain
chunked_vectorinstead of the reader.Backports Required
Release Notes