Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datalake: on demand dlq table creation #24824

Merged
merged 2 commits into from
Jan 17, 2025
Merged

datalake: on demand dlq table creation #24824

merged 2 commits into from
Jan 17, 2025

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Jan 15, 2025 •
edited
Loading

This likely needs to be opt-out. Planning to add it later.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@nvartolomei nvartolomei mentioned this pull request Jan 15, 2025
Closed
7 tasks
@nvartolomei nvartolomei force-pushed the nv/iceberg-dlq-table-mngmt-lifecycle branch from f8052bf to 448160b Compare January 16, 2025 15:28
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Jan 16, 2025
@nvartolomei nvartolomei marked this pull request as ready for review January 16, 2025 15:29
@nvartolomei nvartolomei requested review from andrwng and ztlpn and removed request for andrwng January 16, 2025 15:29
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 16, 2025 •
edited
Loading

CI test results

test results on build#60849
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/60849#01947016-376b-45d1-af3c-9e493a7c7a7b FLAKY 5/6
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60849#01947018-70e1-4947-8383-5388cb39059a FLAKY 2/6
test results on build#60925
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/60925#019475de-e741-465e-ace3-22bd333d3805 FLAKY 1/2

andrwng
andrwng reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much looks good! Though there's some code that landed in the wrong commit

@nvartolomei
datalake: refactor file committer to use table in public interface
7256600 
Want to use the drop_table method for DLQ topics.
@nvartolomei
datalake: on demand dlq table creation
b549b0b 
The table is kept empty for now. Writing will be added later.
@nvartolomei nvartolomei force-pushed the nv/iceberg-dlq-table-mngmt-lifecycle branch from 448160b to b549b0b Compare January 17, 2025 18:51
@nvartolomei
Copy link
Contributor Author

@andrwng thanks for feedback. Everything addressed. 🙇‍♂️

@nvartolomei nvartolomei requested a review from andrwng January 17, 2025 18:57
@nvartolomei nvartolomei enabled auto-merge January 17, 2025 20:26
@nvartolomei nvartolomei merged commit a7e7111 into redpanda-data:dev Jan 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvartolomei @vbotbuildovich @andrwng