-
Notifications
You must be signed in to change notification settings - Fork 679
rptest: move cluster config export to @cluster #27706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rptest: move cluster config export to @cluster #27706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes test execution time by moving cluster configuration export to the @cluster
cleanup phase instead of during service stop. This eliminates duplicate configuration exports when services are stopped multiple times, saving approximately 6 seconds per test.
Key changes:
- Moves
export_cluster_config()
call fromstop()
method to@cluster
cleanup - Adds abstract method definition for
export_cluster_config()
in base class - Extracts configuration export logic into separate method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/rptest/services/redpanda.py | Extracts cluster config export from stop() method and adds abstract method definition |
tests/rptest/services/cluster.py | Calls export_cluster_config() during @cluster cleanup phase |
Retry command for Build#72845please wait until all jobs are finished before running the slash command
|
f10ba82
to
dccc4ab
Compare
dccc4ab moves slightly the config check since in this audit test is produces an exact bad log line (because auditing is misconfigurated, this request fails), so just move it below the BLL check. |
dccc4ab
to
532e7a3
Compare
This should be done only once, don't do it on service stop, but in the @cluster cleanup code, before we stop redpanda. This saves six seconds on every test, since the second export (due to the second stop) took six seconds. Hat tip to Stephan for noticing this.
532e7a3
to
c6d0059
Compare
this push of c6d0059 removes some checks I added a while ago because we needed to swap the |
This should be done only once, don't do it on service stop, but in the @cluster cleanup code, before we stop redpanda.
This saves six seconds on every test, since the second export (due to the second stop) took six seconds. Hat tip to Stephan for noticing this.
Backports Required
Release Notes