Use shadow linking scheduling group in replicator and topic reconciler #27711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Topic reconciler should run in shadow linking scheduling group. Signed-off-by: Michał Maślanka <[email protected]>
Signed-off-by: Michał Maślanka <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds the missing shadow linking scheduling group parameter to the partition replicator and topic reconciler components that were previously omitted when the scheduling group was first introduced.
- Adds scheduling group parameter to
topic_reconcilerconstructor and member variable - Adds scheduling group parameter to
partition_replicatorconstructor with default value and member variable - Updates all instantiation sites to pass the appropriate scheduling group
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/v/cluster_link/topic_reconciler.h | Adds scheduling group parameter to constructor and member variable |
| src/v/cluster_link/topic_reconciler.cc | Implements scheduling group in constructor and adds coroutine switch in execute method |
| src/v/cluster_link/tests/topic_reconciler_test.cc | Updates test to pass default scheduling group to constructor |
| src/v/cluster_link/replication/partition_replicator.h | Adds scheduling group parameter with default value and member variable |
| src/v/cluster_link/replication/partition_replicator.cc | Implements scheduling group in constructor and adds coroutine switches in start/stop methods |
| src/v/cluster_link/replication/link_replication_mgr.cc | Updates replicator instantiation to pass scheduling group |
| src/v/cluster_link/manager.cc | Updates topic reconciler instantiation to pass scheduling group |
CI test resultstest results on build#72869
|
mmaslankaprv
requested review from
bharathv,
oleiman,
michael-redpanda and
joe-redpanda
bharathv
approved these changes
Sep 25, 2025
oleiman
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR introducing shadow linking scheduling group i missed adding it into partition replicator and topic reconciler.
This PR adds the scheduling group for the components that were previously missing it.
Backports Required
Release Notes