ct/l1: erase partition when removing last object leaves it empty #27717
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where removing the last object from a metastore partition would leave behind empty partition metadata in the builder. This caused failures when add_objects() encountered empty partitions that still expected term routing information.
Key changes:
- Added logic to clean up empty partitions when the last object is removed from a builder
- Added regression test to verify the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/v/cloud_topics/level_one/metastore/replicated_metastore.cc |
Adds partition cleanup logic when removing the last object leaves partition empty |
src/v/cloud_topics/level_one/metastore/tests/replicated_metastore_test.cc |
Adds regression test that reproduces and verifies fix for empty partition cleanup |
wdberkeley
previously approved these changes
Sep 24, 2025
We were previously leaving behind empty partitions in the builder. This meant that after a bad object is removed from the builder, the call to replicated_metastore::add_objects() would examine the empty set of objects meant for a given metastore partition, and expect there to be terms routed for that partition. This resulted in the following error: ERROR 2025-09-24 06:14:38,875 [shard 0:main] cloud_topics - replicated_metastore.cc:320 - No term metadata routed to partition 1
andrwng
dismissed stale reviews from wdberkeley, dotnwat, and rockwotj
via
0b4e538
andrwng
force-pushed
the
ct-l1-remove-obj-empty
branch
from
d2387f6 to
0b4e538
Compare
|
Force pushed to rebase and pass the object builder by const ref |
rockwotj
approved these changes
Sep 24, 2025
Retry command for Build#72906please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#72902
test results on build#72906
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously leaving behind empty partitions in the builder. This meant that after a bad object is removed from the builder, the call to replicated_metastore::add_objects() would examine the empty set of objects meant for a given metastore partition, and expect there to be terms routed for that partition. This resulted in the following error:
ERROR 2025-09-24 06:14:38,875 [shard 0:main] cloud_topics - replicated_metastore.cc:320 - No term metadata routed to partition 1
Backports Required
Release Notes