[CORE-13481] model: Log topic_id as base64 #27721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
requested review from
IoannisRP,
a team,
Copilot and
michael-redpanda
and removed request for
a team and
IoannisRP
There was a problem hiding this comment.
Pull Request Overview
This PR implements base64 encoding for topic_id logging to align with KIP-514's recommendation for Topic ID rendering. The change affects how topic IDs are displayed in logs and formatted output throughout the system.
- Adds base64 encoding for topic_id formatting via fmt::formatter specialization
- Implements stream operator overloading for topic_id output consistency
- Updates build dependencies to include the base64 utility module
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/v/model/model.cc | Implements fmt::formatter for topic_id using base64 encoding and adds stream operator |
| src/v/model/fundamental.h | Declares stream operator and fmt::formatter specialization for topic_id |
| src/v/model/BUILD | Adds dependency on utils:base64 module |
BenPope
force-pushed
the
core-13481-topic-id-base64
branch
from
8a6643e to
4153519
Compare
CI test resultstest results on build#72939
test results on build#72953
|
`uuid_t` is used elsewhere, `named_type` forwards `operator<<` to the underlying type, so `topic_id` must become a seperate tpe in order to customise printing. Signed-off-by: Ben Pope <[email protected]>
BenPope
force-pushed
the
core-13481-topic-id-base64
branch
from
4153519 to
a4f5cdf
Compare
michael-redpanda
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIP-514 suggests that Topic IDs should be rendered as base64 encoded, so switch logging to use base64.
Backports Required
Release Notes