[CORE-15023] Cloud Clients: Multipart Batch Delete for ABS and GCS #29103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
force-pushed
the
ct/core-15023/multi-part-delete
branch
from
e12d598 to
c63fe2a
Compare
oleiman
force-pushed
the
ct/core-15023/multi-part-delete
branch
from
c63fe2a to
6c89358
Compare
oleiman
changed the title
oleiman
force-pushed
the
ct/core-15023/multi-part-delete
branch
from
6c89358 to
256dc1c
Compare
Member
Author
|
/ci-repeat 1 |
oleiman
force-pushed
the
ct/core-15023/multi-part-delete
branch
from
256dc1c to
90642ae
Compare
Member
Author
|
/ci-repeat 1 |
Member
Author
|
/cdt |
This is just for batch deletes, which are brand new. We can add unit tests for other requests, but it's not critical at the moment.
This is only needed for GCS, so various identifiers will reflect that. Includes json response body parsing to get GCS-native error reasons.
Very crude request parsing, but it works well enough for existing tests.
- Wire the batch request limit (100) into remote.cc - Add switching logic in s3_client - Update cloud_io/remote_test
Bit simpler than retrofitting s3_client_test. Just flexing the batch delete code.
oleiman
force-pushed
the
ct/core-15023/multi-part-delete
branch
from
90642ae to
c66d0b9
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABS & GCS. Needs some class comments and whatnot and to test against real ABS & GCS, but this feels pretty good as written.
Note that this PR is >50% tests.
PR NEEDS TO BE SPLIT ON ABS/GCS LINE
Backports Required
Release Notes
Improvements