Revert ct read debounce #29119
Open
Revert ct read debounce #29119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts two previous pull requests that introduced cloud topics fetch debouncing functionality. The revert is being performed because the feature needs more testing before deployment.
Key changes:
- Removal of the
cloud_topics_fetch_debounce_enabledconfiguration property - Complete deletion of the read debounce implementation and its tests
- Cleanup of all references to the debounce feature from the data plane implementation
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/v/config/configuration.h | Removed cloud_topics_fetch_debounce_enabled property declaration |
| src/v/config/configuration.cc | Removed initialization of the debounce configuration property |
| src/v/cloud_topics/level_zero/read_debounce/tests/read_debounce_test.cc | Deleted test file for read debounce functionality |
| src/v/cloud_topics/level_zero/read_debounce/tests/read_debounce_bench.cc | Deleted benchmark file for read debounce performance testing |
| src/v/cloud_topics/level_zero/read_debounce/tests/BUILD | Deleted Bazel build configuration for debounce tests |
| src/v/cloud_topics/level_zero/read_debounce/read_debounce.h | Deleted header file containing read debounce class definition |
| src/v/cloud_topics/level_zero/read_debounce/read_debounce.cc | Deleted implementation file for read debounce logic |
| src/v/cloud_topics/level_zero/read_debounce/BUILD | Deleted Bazel build configuration for read debounce library |
| src/v/cloud_topics/level_zero/pipeline/BUILD | Removed read_debounce package visibility declarations |
| src/v/cloud_topics/data_plane_impl.cc | Removed read debounce service initialization and lifecycle management |
| src/v/cloud_topics/BUILD | Removed read_debounce dependency from cloud_topics library |
rockwotj
approved these changes
Dec 25, 2025
Collaborator
CI test resultstest results on build#78412
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts
ct/l0: fix heap-use-after-free inread_debounce#29118Needs more testing.
Backports Required
Release Notes