Skip to content

Conversation

@WillemKauf
Copy link
Contributor

@WillemKauf WillemKauf commented Jan 5, 2026

And also re-enforce use of clang-format before committing C++ changes.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.3.x
  • v25.2.x
  • v25.1.x

Release Notes

  • none

@WillemKauf WillemKauf requested a review from rockwotj January 5, 2026 16:13
@WillemKauf WillemKauf requested a review from a team as a code owner January 5, 2026 16:13
@WillemKauf WillemKauf requested review from PrzemekZglinicki and Copilot and removed request for a team January 5, 2026 16:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Copilot instructions documentation by adding guidelines for Protobuf development and clarifying C++ formatting requirements. The changes emphasize running clang-format before committing rather than just before PR submission, and establish clear documentation for the Protobuf codebase structure.

Key changes:

  • Added Protobuf-specific section documenting the proto/ directory, formatting requirements, and reference to coding guidelines
  • Updated C++ linting guidance to emphasize running clang-format before committing changes

@WillemKauf
Copy link
Contributor Author

@rockwotj does this seem helpful at all to you?

Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems good to me

@WillemKauf WillemKauf merged commit 2f4bd6d into redpanda-data:dev Jan 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants