-
Notifications
You must be signed in to change notification settings - Fork 709
security/tests: add OIDC authenticate group benchmark tests #29163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security/tests: add OIDC authenticate group benchmark tests #29163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive benchmark tests for the OIDC authenticate function to measure group claim extraction performance. The benchmarks test various scenarios including different group counts (0, 1, 10, 100, 1000), different formats (JSON array vs comma-delimited string), and different nesting behaviors (flat vs nested with suffix extraction).
Key Changes:
- Added a new benchmark test file
oidc_authenticator_bench.ccwith 17 performance test cases - Updated the BUILD file to include the new benchmark target
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v/security/tests/oidc_authenticator_bench.cc | New benchmark test file implementing 17 performance tests for OIDC authenticate function across different group configurations |
| src/v/security/tests/BUILD | Added new redpanda_cc_bench target for the OIDC authenticator benchmark |
CI test resultstest results on build#78618
|
michael-redpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, couple of nits. Can you also post results?
ff1fb44 to
83bc4a5
Compare
|
Force push to address comments. |
This commit adds benchmark tests for the OIDC `authenticate` function
testing group claim extraction performance across multiple dimensions:
- Group counts: 0, 1, 10, 100, and 1000 groups
- Formats: JSON array (["g1", "g2"]) vs comma-delimited string ("g1,g2")
- Nesting: flat names vs nested paths with suffix extraction
83bc4a5 to
6a6fc28
Compare
|
Force push - forgot to run clang_format |
|
Here are the results I gathered running locally on my dev machine: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
michael-redpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit adds benchmark tests for the OIDC
authenticatefunction testing group claim extraction performance across multiple dimensions:CORE-15161
Backports Required
Release Notes