[v25.2.x] admin: update deprecated method_whitelist to allowed_methods #29173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method_whitelist parameter in urllib3's Retry class has been deprecated in favor of allowed_methods. This change ensures compatibility with newer versions of urllib3. Signed-off-by: Michael Boquard <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deprecated method_whitelist parameter to allowed_methods in urllib3's Retry class initialization. The change ensures compatibility with newer versions of urllib3 where the old parameter name has been deprecated.
Key changes:
- Replaced deprecated
method_whitelistparameter withallowed_methodsin the Retry class instantiation - Added a clarifying comment that the
Nonevalue means all HTTP methods will be retried
michael-redpanda
changed the title
Collaborator
CI test resultstest results on build#78658
|
BenPope
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method_whitelist parameter in urllib3's Retry class has been deprecated in favor of allowed_methods. This change ensures compatibility with newer versions of urllib3.
Backports Required
Release Notes