-
Notifications
You must be signed in to change notification settings - Fork 709
CORE-14878: Migrate "Users" Admin API v1 Security Endpoints to v2 ConnectRPC API #29174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nguyen-andrew
merged 13 commits into
redpanda-data:dev
from
nguyen-andrew:admin-api-v2-users
Jan 17, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0d0d7db
admin: Add SCRAM credential management stubs in Admin API v2
nguyen-andrew 60b3def
dt/pb: Generate Ducktape protobuf clients
nguyen-andrew 2ad51a8
admin: Implement SCRAM credential creation in Admin API v2
nguyen-andrew fbf3c3b
admin: Implement SCRAM credential retrieval in Admin API v2
nguyen-andrew 43f333a
admin: Implement SCRAM credential listing in Admin API v2
nguyen-andrew 8cca409
admin: Implement SCRAM credential update in Admin API v2
nguyen-andrew a5981c4
admin: Implement SCRAM credential deletion in Admin API v2
nguyen-andrew 0c8e68c
admin/tests: unit tests for match_scram_credential
nguyen-andrew 4a59a03
admin/tests: unit tests for validate_scram_credential_name
nguyen-andrew 3119d04
admin/tests: unit tests for validate_pb_scram_credential
nguyen-andrew 4316b5d
admin/tests: unit tests for convert_to_security_scram_credential
nguyen-andrew 64871eb
admin/tests: add unit tests for convert_to_pb_scram_credential
nguyen-andrew 9596930
dt: Extend SCRAM tests to cover both v1 and v2 Admin APIs
nguyen-andrew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider just changing the file name to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2026 Redpanda Data, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package redpanda.core.common.v1; | ||
|
|
||
| import "proto/redpanda/core/pbgen/options.proto"; | ||
|
|
||
| option (pbgen.cpp_namespace) = "proto::common"; | ||
|
|
||
| // Valid SCRAM mechanisms | ||
| enum ScramMechanism { | ||
| SCRAM_MECHANISM_UNSPECIFIED = 0; | ||
| // SCRAM-SHA-256 | ||
| SCRAM_MECHANISM_SCRAM_SHA_256 = 1; | ||
| // SCRAM-SHA-512 | ||
| SCRAM_MECHANISM_SCRAM_SHA_512 = 2; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add a
password_set_atfield (a, laredpanda/proto/redpanda/core/admin/v2/shadow_link.proto
Lines 466 to 469 in c3e36a2
I do think this may result in having to make controller updates to store the timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this was part of the original mini rfc but omitted it in this change to try to minimize/isolate the controller changes. Discussed this and decided to split this off to a separate follow-on task (CORE-15278).