create proper action

src/constants.ts

@@ -0,0 +1 @@
+export const API_ACTION_PREFIX = '@@saga-query';

src/index.ts

@@ -3,3 +3,4 @@ export * from './api';
 export * from './types';
 export * from './fetch';
 export * from './middleware';
+export * from './constants';

src/middleware.ts

@@ -17,7 +17,7 @@ import {
   ApiCtx,
   Next,
 } from './types';
-import { isObject } from './util';
+import { isObject, createAction } from './util';
 
 export function* queryCtx<Ctx extends ApiCtx = ApiCtx>(ctx: Ctx, next: Next) {
   if (!ctx.request) ctx.request = { url: '', method: 'GET' };
@@ -105,18 +105,8 @@ interface UndoCtx<R = any, P = any> extends ApiCtx {
   undoable: boolean;
 }
 
-export const doIt = () => {
-  const type = '@@saga-query/DO_IT';
-  const action = { type };
-  action.toString = () => type;
-  return action;
-};
-export const undo = () => {
-  const type = '@@saga-query/UNDO';
-  const action = { type };
-  action.toString = () => type;
-  return action;
-};
+export const doIt = createAction('DO_IT');
+export const undo = createAction('UNDO');
 export function undoer<Ctx extends UndoCtx = UndoCtx>(
   doItType = `${doIt}`,
   undoType = `${undo}`,

src/pipe.ts

@@ -13,6 +13,7 @@ import {
   CreateActionWithPayload,
   PipeCtx,
 } from './types';
+import { API_ACTION_PREFIX } from './constants';
 
 export function compose<Ctx = any>(middleware: Middleware<Ctx>[]) {
   if (!Array.isArray(middleware)) {
@@ -75,7 +76,6 @@ export const defaultOnError = (err: Error) => {
   throw err;
 };
 
-export const API_ACTION_PREFIX = '@@saga-query';
 export function createPipe<Ctx extends PipeCtx = PipeCtx<any>>({
   onError = defaultOnError,
 }: {

src/util.test.ts

@@ -0,0 +1,13 @@
+import test from 'ava';
+import { createAction } from './util';
+import { API_ACTION_PREFIX } from './constants';
+
+test('createAction - should return action type when stringified', (t) => {
+  const undo = createAction('UNDO');
+  t.assert(`${API_ACTION_PREFIX}/UNDO` === `${undo}`);
+});
+
+test('createAction - return object with type', (t) => {
+  const undo = createAction('UNDO');
+  t.deepEqual(undo(), { type: `${API_ACTION_PREFIX}/UNDO` });
+});

src/util.ts

@@ -1,2 +1,10 @@
+import { API_ACTION_PREFIX } from './constants';
 export const isFn = (fn?: any) => fn && typeof fn === 'function';
 export const isObject = (obj?: any) => typeof obj === 'object' && obj !== null;
+export const createAction = (curType: string) => {
+  if (!curType) throw new Error('createAction requires non-empty string');
+  const type = `${API_ACTION_PREFIX}/${curType}`;
+  const action = () => ({ type });
+  action.toString = () => type;
+  return action;
+};