-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to React 19 #2172
Closed
Closed
Migrate to React 19 #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
aryaemami59
force-pushed
the
migrate-to-react-19
branch
2 times, most recently
from
May 16, 2024 15:03
b7877bc
to
93b6f07
Compare
✅ Deploy Preview for react-redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
August 10, 2024 12:41
923eff2
to
53261de
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
6 times, most recently
from
September 13, 2024 22:32
1ed9e74
to
ac01df2
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
4 times, most recently
from
October 8, 2024 22:20
67a048a
to
258edeb
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
14 times, most recently
from
October 18, 2024 06:43
f219d06
to
5d32aee
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
2 times, most recently
from
December 6, 2024 18:41
054b5fc
to
55e7d62
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
December 6, 2024 19:11
55e7d62
to
f0063bf
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
December 6, 2024 21:09
f0063bf
to
a38fd8f
Compare
Closed
3 tasks
14 tasks
Merged in #2216 , which is a copy-paste of this PR's commits into a new branch inside this repo. Same work, different PR number! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #2216 (same code, new branch)
This PR:
react
andreact-dom
to v19.@types/react
and@types/react-dom
to v19 according to the React 19 migration guide.react-test-renderer
package as recommended in the React 19 migration guide.@testing-library/react
to latest version.@testing-library/jest-dom
to latest version.ReactDOM.render
calls with therender
function from@testing-library/react
as recommended in the React 19 migration guide.ReactDOM.unmountComponentAtNode
calls with theunmount
function from@testing-library/react
as recommended in the React 19 migration guide.renderHook
function from@testing-library/react-hooks
to@testing-library/react
as recommended by A Note about React 18 Support and react-hooks-testing-library React 18 Migration guide.@testing-library/react-hooks
package.renderHook
calls according to react-hooks-testing-library React 18 Migration guide.react-is
implementation.Click to expand
In [PR#28813](https://github.com/Rename the react.element symbol to react.transitional.element facebook/react#28813) `react-is` changed the `REACT_ELEMENT_TYPE` symbol from `'react.element'` to `'react.transitional.element'`. We want our changes to be non-breaking and backwards-compatible so we conditionally set the `REACT_ELEMENT_TYPE` based on the detected version of React. While this is not ideal, the `react-is` package is `CJS` and not very tree-shakable. So for now we want to inline it as to not add unnecessary weight to bundle sizes, not to mention the conditional React version check helps keep our changes backwards-compatible.react-is
related detailsrtl.cleanup
function calls insideafterEach
hooks as per@testing-library/react
docs, it is done automatically.react
and@types/react
inpeerDependencies
to include version 19.