-
Notifications
You must be signed in to change notification settings - Fork 994
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix storybook-vite not starting when
auth.ts
contains named imports…
- Loading branch information
1 parent
05f301d
commit ce9c723
Showing
3 changed files
with
25 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
- Fix storybook-vite not starting when `auth.ts` contains named imports after `createAuth` (#11593) by @Philzen | ||
|
||
This change fixes an issue with our internal storybook mocks. Previous to this you might find that your storybook would fail with an error like: | ||
|
||
``` | ||
3:49:51 PM [vite] Internal server error: Transform failed with 1 error: | ||
…/web/src/auth.ts:2:9: ERROR: Expected identifier but found "," | ||
Plugin: vite:esbuild | ||
File: …/web/src/auth.ts:3:6 | ||
Expected identifier but found "," | ||
1 | import { createAuthentication as createAuth } from '@redwoodjs/testing/dist/web/mockAuth.js' | ||
2 | import { , createDbAuthClient } from '@redwoodjs/auth-dbauth-web'; | ||
| ^ | ||
3 | const dbAuthClient = createDbAuthClient(); | ||
4 | export const { | ||
``` | ||
|
||
This was due to a bug in our handling of imports which this change fixes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters