Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): do not enforce changeset entry for certain milestones #10858

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

Josh-Walker-GM
Copy link
Collaborator

Right now the check will enforce a changeset entry for any PR. We have noticed this can be a bit excessive for the current RSC/SSR work. These features are not scheduled for stable release in the near future and so requiring a changeset on every related PR can produce changesets which are of little value - descriptions of fixes for features that have never been released in stables.

@Josh-Walker-GM Josh-Walker-GM self-assigned this Jun 19, 2024
@Josh-Walker-GM Josh-Walker-GM added this to the chore milestone Jun 19, 2024
@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Jun 19, 2024
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, next-release, SSR Jun 19, 2024
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review June 19, 2024 00:17
@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) June 19, 2024 00:17
@Josh-Walker-GM Josh-Walker-GM merged commit 45a2d57 into main Jun 19, 2024
51 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw/ci-skip-changeset-check-for-milestones branch June 19, 2024 00:34
Josh-Walker-GM added a commit that referenced this pull request Jun 25, 2024
)

Right now the check will enforce a changeset entry for any PR. We have
noticed this can be a bit excessive for the current RSC/SSR work. These
features are not scheduled for stable release in the near future and so
requiring a changeset on every related PR can produce changesets which
are of little value - descriptions of fixes for features that have never
been released in stables.
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants