breaking: remove webpack #10867
Merged
breaking: remove webpack #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
commented
Jun 25, 2024
|
I'll update the required CI checks once we've approved this. |
|
@Josh-Walker-GM shall we find a time to go through the routes autoloader? It seems fine but I wanted to discuss/understand why the style of import statements changed! |
|
@Josh-Walker-GM @dac09 I'd like to be part of that discussion too. I want to make sure I'm up-to-date on how the router works. |
This was referenced Jul 19, 2024
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
…ojects (#11458) Fixes #11457 In #10867 I removed the presets by default and they are only included in specific cases - for jest, for prerender. It looks like I forgot to consider the case of linting javascript projects. I therefore re-enable these presets in that specific case. It's already on my medium term wish list to simplify and rip out as much of our babel config/reliance as we can. It would be better if this was all just simpler and didn't have as many branches. I also introduced a copy of `isTypeScriptProject` into `@redwoodjs/project-config`. It doesn't add any dependencies to that package and it relies on the functionality already provided in it. I will make a note to refactor our existing usage to use this one. I think that would be better.
Josh-Walker-GM
added a commit
that referenced
this pull request
Sep 6, 2024
…ojects (#11458) Fixes #11457 In #10867 I removed the presets by default and they are only included in specific cases - for jest, for prerender. It looks like I forgot to consider the case of linting javascript projects. I therefore re-enable these presets in that specific case. It's already on my medium term wish list to simplify and rip out as much of our babel config/reliance as we can. It would be better if this was all just simpler and didn't have as many branches. I also introduced a copy of `isTypeScriptProject` into `@redwoodjs/project-config`. It doesn't add any dependencies to that package and it relies on the functionality already provided in it. I will make a note to refactor our existing usage to use this one. I think that would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first attempt at removing webpack from the framework. I started with just removing the bundler config option and kept pulling the threads until it got to this stage. This will have touched a lot of files and could in theory be broken down into smaller PRs if we find the need to.
This will be a breaking change. The follow are the breaking changes I have identified:
prebuildWebFileis function no longer exported from@redwoodjs/babel-configpackage@redwoodjs/cli-storybookhas been removedyarn rw buildno longer accepts the--statsflagyarn rw devno longer accepts the--watchNodeModulesflagyarn rw setup custom-web-indexcommand has been removedyarn rw setup webpackhas been removed@redwoodjs/coreno longer provides@redwoodjs/core/config/*filesweb.bundlerTOML config option has been removed@redwoodjs/testingno longer provides storybook config files@redwoodjs/testingno longer provides aStorybookProviderwebpackbin has been removed from@redwoodjs/webWIP
rw test webcommandpackages/babel-config/src/api.tspackages/babel-config/src/plugins/babel-plugin-redwood-routes-auto-loader.tspackages/cli/src/commands/dev.jspackages/prerender/src/babelPlugins/babel-plugin-redwood-prerender-media-imports.tspackages/project-config/src/paths.tspackages/testing/src/web/fileMock.tspackages/vite/src/build/__tests__/nestedPages.test.tspackages/vite/src/lib/envVarDefinitions.tspackages/vite/src/lib/registerFwGlobalsAndShims.tspackages/web/src/assetImports.tspackages/web/src/config.tsFollow up items