chore(vite): Don't exclude Router in attw check #11031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jul 21, 2024
…-dual-pkg * 'main' of github.com:redwoodjs/redwood: chore(vite): Don't exclude Router in attw check (redwoodjs#11031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attw didn't have any issues with Router (except for node10, but we don't care about that). So we might as well include it in the checks. Ideally Router will move to another package, but for now it's in the vite package and no reason to not have the package.json exports be correct when there's no extra effort in doing so.